Skip to content

Commit

Permalink
staging: rtl8723bs: fix comparsion to true/false and brace issues
Browse files Browse the repository at this point in the history
Use if(x) and if(!x) instead of comparsion to true/false.
Reported by checkpatch.

Remove unrequired braces from single if else statement.
Add missing space after else: else{ -> else {

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Michael Straube authored and Greg Kroah-Hartman committed Jul 2, 2018
1 parent 790d5d2 commit d2ab991
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
8 changes: 4 additions & 4 deletions drivers/staging/rtl8723bs/core/rtw_btcoex.c
Original file line number Diff line number Diff line change
Expand Up @@ -77,14 +77,14 @@ void rtw_btcoex_SuspendNotify(struct adapter *padapter, u8 state)

void rtw_btcoex_HaltNotify(struct adapter *padapter)
{
if (false == padapter->bup) {
if (!padapter->bup) {
DBG_871X(FUNC_ADPT_FMT ": bup =%d Skip!\n",
FUNC_ADPT_ARG(padapter), padapter->bup);

return;
}

if (true == padapter->bSurpriseRemoved) {
if (padapter->bSurpriseRemoved) {
DBG_871X(FUNC_ADPT_FMT ": bSurpriseRemoved =%d Skip!\n",
FUNC_ADPT_ARG(padapter), padapter->bSurpriseRemoved);

Expand Down Expand Up @@ -198,11 +198,11 @@ void rtw_btcoex_RejectApAggregatedPacket(struct adapter *padapter, u8 enable)
pmlmeinfo = &padapter->mlmeextpriv.mlmext_info;
psta = rtw_get_stainfo(&padapter->stapriv, get_bssid(&padapter->mlmepriv));

if (true == enable) {
if (enable) {
pmlmeinfo->accept_addba_req = false;
if (psta)
send_delba(padapter, 0, psta->hwaddr);
} else{
} else {
pmlmeinfo->accept_addba_req = true;
}
}
Expand Down
5 changes: 2 additions & 3 deletions drivers/staging/rtl8723bs/core/rtw_efuse.c
Original file line number Diff line number Diff line change
Expand Up @@ -580,11 +580,10 @@ void EFUSE_ShadowMapUpdate(

EFUSE_GetEfuseDefinition(padapter, efuseType, TYPE_EFUSE_MAP_LEN, (void *)&mapLen, bPseudoTest);

if (pEEPROM->bautoload_fail_flag == true) {
if (pEEPROM->bautoload_fail_flag)
memset(pEEPROM->efuse_eeprom_data, 0xFF, mapLen);
} else{
else
Efuse_ReadAllMap(padapter, efuseType, pEEPROM->efuse_eeprom_data, bPseudoTest);
}

/* PlatformMoveMemory((void *)&pHalData->EfuseMap[EFUSE_MODIFY_MAP][0], */
/* void *)&pHalData->EfuseMap[EFUSE_INIT_MAP][0], mapLen); */
Expand Down

0 comments on commit d2ab991

Please sign in to comment.