Skip to content

Commit

Permalink
drm/xe: Increase the XE_PL_TT watermark
Browse files Browse the repository at this point in the history
The XE_PL_TT watermark was set to 50% of system memory.
The idea behind that was unclear since the net effect is that
TT memory will be evicted to TTM_PL_SYSTEM memory if that
watermark is exceeded, requiring PPGTT rebinds and dma
remapping. But there is no similar watermark for TTM_PL_1SYSTEM
memory.

The TTM functionality that tries to swap out system memory to
shmem objects if a 50% limit of total system memory is reached
is orthogonal to this, and with the shrinker added, it's no
longer in effect.

Replace the 50% TTM_PL_TT limit with a 100% limit, in effect
allowing all graphics memory to be bound to the device unless it
has been swapped out by the shrinker.

Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Link: https://lore.kernel.org/intel-xe/20250305092220.123405-8-thomas.hellstrom@linux.intel.com
  • Loading branch information
Thomas Hellström committed Mar 5, 2025
1 parent 00c8efc commit d2d5f6d
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/gpu/drm/xe/xe_ttm_sys_mgr.c
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,8 @@ int xe_ttm_sys_mgr_init(struct xe_device *xe)
u64 gtt_size;

si_meminfo(&si);
/* Potentially restrict amount of TT memory here. */
gtt_size = (u64)si.totalram * si.mem_unit;
/* TTM limits allocation of all TTM devices by 50% of system memory */
gtt_size /= 2;

man->use_tt = true;
man->func = &xe_ttm_sys_mgr_func;
Expand Down

0 comments on commit d2d5f6d

Please sign in to comment.