Skip to content

Commit

Permalink
tasklets: Replace barrier() with cpu_relax() in tasklet_unlock_wait()
Browse files Browse the repository at this point in the history
A barrier() in a tight loop which waits for something to happen on a remote
CPU is a pointless exercise. Replace it with cpu_relax() which allows HT
siblings to make progress.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/r/20210309084241.249343366@linutronix.de
  • Loading branch information
Thomas Gleixner committed Mar 17, 2021
1 parent 6b2c339 commit d2da74d
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion include/linux/interrupt.h
Original file line number Diff line number Diff line change
Expand Up @@ -672,7 +672,8 @@ static inline void tasklet_unlock(struct tasklet_struct *t)

static inline void tasklet_unlock_wait(struct tasklet_struct *t)
{
while (test_bit(TASKLET_STATE_RUN, &(t)->state)) { barrier(); }
while (test_bit(TASKLET_STATE_RUN, &t->state))
cpu_relax();
}
#else
#define tasklet_trylock(t) 1
Expand Down

0 comments on commit d2da74d

Please sign in to comment.