Skip to content

Commit

Permalink
fail_function: fix wrong use of fei_attr_remove()
Browse files Browse the repository at this point in the history
If register_kprobe() fails, the new attr is not added to the list yet, so
it should call fei_attr_free() intstead.

Link: https://lkml.kernel.org/r/20220826073337.2085798-3-yangyingliang@huawei.com
Fixes: 4b1a29a ("error-injection: Support fault injection framework")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
  • Loading branch information
Yang Yingliang authored and Andrew Morton committed Sep 12, 2022
1 parent cef9f5f commit d2e8543
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion kernel/fail_function.c
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ static ssize_t fei_write(struct file *file, const char __user *buffer,

ret = register_kprobe(&attr->kp);
if (ret) {
fei_attr_remove(attr);
fei_attr_free(attr);
goto out;
}
fei_debugfs_add_attr(attr);
Expand Down

0 comments on commit d2e8543

Please sign in to comment.