Skip to content

Commit

Permalink
dt-bindings: iommu: arm,smmu-v3: Relax order of interrupt names
Browse files Browse the repository at this point in the history
The QEMU devicetree uses a different order for SMMUv3 interrupt names,
and there isn't a good reason for enforcing a specific order. Since all
interrupt lines are optional, operating systems should not expect a
fixed interrupt array layout; they should instead match each interrupt
to its name individually. Besides, as a result of commit e478385
("dt-bindings: iommu: arm,smmu-v3: make PRI IRQ optional"), "cmdq-sync"
and "priq" are already permutable. Relax the interrupt-names array
entirely by allowing any permutation, incidentally making the schema
more readable.

Note that dt-validate won't allow duplicate names here so we don't need
to specify maxItems or add additional checks, it's quite neat.

Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
Acked-by: Will Deacon <will@kernel.org>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20220916133145.1910549-1-jean-philippe@linaro.org
Signed-off-by: Joerg Roedel <jroedel@suse.de>
  • Loading branch information
Jean-Philippe Brucker authored and Joerg Roedel committed Sep 26, 2022
1 parent 7e18e42 commit d2f2f1d
Showing 1 changed file with 5 additions and 10 deletions.
15 changes: 5 additions & 10 deletions Documentation/devicetree/bindings/iommu/arm,smmu-v3.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,16 +39,11 @@ properties:
any others.
- minItems: 1
items:
- enum:
- eventq # Event Queue not empty
- gerror # Global Error activated
- const: gerror
- enum:
- cmdq-sync # CMD_SYNC complete
- priq # PRI Queue not empty
- enum:
- cmdq-sync
- priq
enum:
- eventq # Event Queue not empty
- gerror # Global Error activated
- cmdq-sync # CMD_SYNC complete
- priq # PRI Queue not empty

'#iommu-cells':
const: 1
Expand Down

0 comments on commit d2f2f1d

Please sign in to comment.