Skip to content

Commit

Permalink
ASoC: nau8824: Fix NAU8824_JACK_LOGIC define
Browse files Browse the repository at this point in the history
The NAU8824_JACK_LOGIC define was wrong, for active high jack-detect
to work bit 1 needs to be set, rather then bit 0.

The correct bit was found in the Android kernel source dump for
a Cyberbook T116 tablet; and this was also tested on that same tablet.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20211002211459.110124-1-hdegoede@redhat.com
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Hans de Goede authored and Mark Brown committed Oct 4, 2021
1 parent 6e037b7 commit d316597
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sound/soc/codecs/nau8824.h
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@
/* JACK_DET_CTRL (0x0D) */
#define NAU8824_JACK_EJECT_DT_SFT 2
#define NAU8824_JACK_EJECT_DT_MASK (0x3 << NAU8824_JACK_EJECT_DT_SFT)
#define NAU8824_JACK_LOGIC 0x1
#define NAU8824_JACK_LOGIC (0x1 << 1)


/* INTERRUPT_SETTING_1 (0x0F) */
Expand Down

0 comments on commit d316597

Please sign in to comment.