Skip to content

Commit

Permalink
x86/asm/64: Drop __cacheline_aligned from struct x86_hw_tss
Browse files Browse the repository at this point in the history
Historically, the entire TSS + io bitmap structure was cacheline
aligned, but commit ca241c7 ("x86: unify tss_struct") changed it
(presumably inadvertently) so that the fixed-layout hardware part is
cacheline-aligned and the io bitmap is after the padding.  This wastes
24 bytes (the hardware part should be 104 bytes, but this pads it to
128 bytes) and, serves no purpose, and causes sizeof(struct
x86_hw_tss) to have a confusing value.

Drop the pointless alignment.

Signed-off-by: Andy Lutomirski <luto@kernel.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
  • Loading branch information
Andy Lutomirski authored and Paolo Bonzini committed Feb 21, 2017
1 parent 8c2e41f commit d3273de
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/x86/include/asm/processor.h
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ struct x86_hw_tss {
u16 reserved5;
u16 io_bitmap_base;

} __attribute__((packed)) ____cacheline_aligned;
} __attribute__((packed));
#endif

/*
Expand Down

0 comments on commit d3273de

Please sign in to comment.