Skip to content

Commit

Permalink
scsi: ibmvscsis: Increase INITIAL_SRP_LIMIT to 1024
Browse files Browse the repository at this point in the history 
[ Upstream commit 0bade8e ]

The adapter request_limit is hardcoded to be INITIAL_SRP_LIMIT which is
currently an arbitrary value of 800. Increase this value to 1024 which
better matches the characteristics of the typical IBMi Initiator that
supports 32 LUNs and a queue depth of 32.

This change also has the secondary benefit of being a power of two as
required by the kfifo API. Since, Commit ab9bb63 ("Partially revert
"kfifo: fix kfifo_alloc() and kfifo_init()"") the size of IU pool for each
target has been rounded down to 512 when attempting to kfifo_init() those
pools with the current request_limit size of 800.

Link: https://lore.kernel.org/r/20220322194443.678433-1-tyreld@linux.ibm.com
Signed-off-by: Tyrel Datwyler <tyreld@linux.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Tyrel Datwyler authored and Greg Kroah-Hartman committed Apr 20, 2022
1 parent b9a110f commit d347870
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@

#define IBMVSCSIS_VERSION "v0.2"

#define INITIAL_SRP_LIMIT 800
#define INITIAL_SRP_LIMIT 1024
#define DEFAULT_MAX_SECTORS 256
#define MAX_TXU 1024 * 1024

Expand Down

0 comments on commit d347870

Please sign in to comment.