Skip to content

Commit

Permalink
net: change Exar/Neterion menu items to be alphabetical
Browse files Browse the repository at this point in the history
Neterion was standalone for several years, then acquired by Exar and
shutdown in 11 months without ever making any new Exar branded adapters.
Users would probably think of them as Neterion and not Exar (as there
have been no follow-on adapters and the vast majority ever sold were
under the Neterion name).

6c541b4 ("net: ethernet: Sort Kconfig sourcing alphabetically")
sorted Kconfig sourcing based on directory names, but in a couple cases,
the menu item text is quite different from the directory name and is not
sorted correctly:

  drivers/net/ethernet/neterion/Kconfig    => "Exar devices"

To address that and clear up any confusion about the name, "Exar" was
changed to "Neterion (Exar)" and the relevant entries in the Makefile
and Kconfig were reordered to match the alphabetical organization.

Inspired-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jon Mason authored and David S. Miller committed Aug 1, 2018
1 parent 969d509 commit d39db3b
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 11 deletions.
2 changes: 1 addition & 1 deletion drivers/net/ethernet/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ source "drivers/net/ethernet/huawei/Kconfig"
source "drivers/net/ethernet/i825xx/Kconfig"
source "drivers/net/ethernet/ibm/Kconfig"
source "drivers/net/ethernet/intel/Kconfig"
source "drivers/net/ethernet/neterion/Kconfig"
source "drivers/net/ethernet/xscale/Kconfig"

config JME
Expand Down Expand Up @@ -128,6 +127,7 @@ config FEALNX
cards. <http://www.myson.com.tw/>

source "drivers/net/ethernet/natsemi/Kconfig"
source "drivers/net/ethernet/neterion/Kconfig"
source "drivers/net/ethernet/netronome/Kconfig"
source "drivers/net/ethernet/ni/Kconfig"
source "drivers/net/ethernet/8390/Kconfig"
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/ethernet/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ obj-$(CONFIG_NET_VENDOR_DEC) += dec/
obj-$(CONFIG_NET_VENDOR_DLINK) += dlink/
obj-$(CONFIG_NET_VENDOR_EMULEX) += emulex/
obj-$(CONFIG_NET_VENDOR_EZCHIP) += ezchip/
obj-$(CONFIG_NET_VENDOR_EXAR) += neterion/
obj-$(CONFIG_NET_VENDOR_FARADAY) += faraday/
obj-$(CONFIG_NET_VENDOR_FREESCALE) += freescale/
obj-$(CONFIG_NET_VENDOR_FUJITSU) += fujitsu/
Expand All @@ -60,6 +59,7 @@ obj-$(CONFIG_NET_VENDOR_MOXART) += moxa/
obj-$(CONFIG_NET_VENDOR_MYRI) += myricom/
obj-$(CONFIG_FEALNX) += fealnx.o
obj-$(CONFIG_NET_VENDOR_NATSEMI) += natsemi/
obj-$(CONFIG_NET_VENDOR_NETERION) += neterion/
obj-$(CONFIG_NET_VENDOR_NETRONOME) += netronome/
obj-$(CONFIG_NET_VENDOR_NI) += ni/
obj-$(CONFIG_NET_NETX) += netx-eth.o
Expand Down
23 changes: 14 additions & 9 deletions drivers/net/ethernet/neterion/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -2,25 +2,28 @@
# Exar device configuration
#

config NET_VENDOR_EXAR
bool "Exar devices"
config NET_VENDOR_NETERION
bool "Neterion (Exar) devices"
default y
depends on PCI
---help---
If you have a network (Ethernet) card belonging to this class, say Y.

Note that the answer to this question doesn't directly affect the
kernel: saying N will just cause the configurator to skip all
the questions about Exar cards. If you say Y, you will be asked for
your specific card in the following questions.
the questions about Neterion/Exar cards. If you say Y, you will be
asked for your specific card in the following questions.

if NET_VENDOR_EXAR
if NET_VENDOR_NETERION

config S2IO
tristate "Exar Xframe 10Gb Ethernet Adapter"
tristate "Neterion (Exar) Xframe 10Gb Ethernet Adapter"
depends on PCI
---help---
This driver supports Exar Corp's Xframe Series 10Gb Ethernet Adapters.
These were originally released from S2IO, which renamed itself
Neterion. So, the adapters might be labeled as either one, depending
on its age.

More specific information on configuring the driver is in
<file:Documentation/networking/s2io.txt>.
Expand All @@ -29,11 +32,13 @@ config S2IO
will be called s2io.

config VXGE
tristate "Exar X3100 Series 10GbE PCIe Server Adapter"
tristate "Neterion (Exar) X3100 Series 10GbE PCIe Server Adapter"
depends on PCI
---help---
This driver supports Exar Corp's X3100 Series 10 GbE PCIe
I/O Virtualized Server Adapter.
I/O Virtualized Server Adapter. These were originally released from
Neterion, which was later acquired by Exar. So, the adapters might be
labeled as either one, depending on its age.

More specific information on configuring the driver is in
<file:Documentation/networking/vxge.txt>.
Expand All @@ -50,4 +55,4 @@ config VXGE_DEBUG_TRACE_ALL
the vxge driver. By default only few debug trace statements are
enabled.

endif # NET_VENDOR_EXAR
endif # NET_VENDOR_NETERION

0 comments on commit d39db3b

Please sign in to comment.