Skip to content

Commit

Permalink
[NETFILTER]: nfnetlink_log: remove fallback to group 0
Browse files Browse the repository at this point in the history
Don't fallback to group 0 if no instance can be found for the given group.
This potentially confuses the listener and is not what the user configured.
Also remove the ring buffer spamming that happens when rules are set up
before the logging daemon is started.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Patrick McHardy authored and David S. Miller committed Apr 26, 2007
1 parent 3b5018d commit d3a2c3c
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions net/netfilter/nfnetlink_log.c
Original file line number Diff line number Diff line change
Expand Up @@ -584,12 +584,7 @@ nfulnl_log_packet(unsigned int pf,

inst = instance_lookup_get(li->u.ulog.group);
if (!inst)
inst = instance_lookup_get(0);
if (!inst) {
PRINTR("nfnetlink_log: trying to log packet, "
"but no instance for group %u\n", li->u.ulog.group);
return;
}

plen = 0;
if (prefix)
Expand Down

0 comments on commit d3a2c3c

Please sign in to comment.