Skip to content

Commit

Permalink
drm/xe: Simplify final return from xe_irq_install()
Browse files Browse the repository at this point in the history
At the end of the function, we will always return err no matter it's
value. Simplify this by just returning the result of
drmm_add_action_or_reset().

Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Link: https://lore.kernel.org/r/20230915220233.59736-1-gustavo.sousa@intel.com
Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
  • Loading branch information
Gustavo Sousa authored and Rodrigo Vivi committed Dec 21, 2023
1 parent fc678ec commit d435a03
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions drivers/gpu/drm/xe/xe_irq.c
Original file line number Diff line number Diff line change
Expand Up @@ -592,11 +592,7 @@ int xe_irq_install(struct xe_device *xe)

xe_irq_postinstall(xe);

err = drmm_add_action_or_reset(&xe->drm, irq_uninstall, xe);
if (err)
return err;

return err;
return drmm_add_action_or_reset(&xe->drm, irq_uninstall, xe);
}

void xe_irq_shutdown(struct xe_device *xe)
Expand Down

0 comments on commit d435a03

Please sign in to comment.