Skip to content

Commit

Permalink
net: check return value for dst_alloc
Browse files Browse the repository at this point in the history
return value of dst_alloc must be checked before use

Signed-off-by: Madalin Bucur <madalin.bucur@freescale.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Madalin Bucur authored and David S. Miller committed Sep 27, 2011
1 parent 2015de5 commit d4cae56
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions net/xfrm/xfrm_policy.c
Original file line number Diff line number Diff line change
Expand Up @@ -1349,14 +1349,16 @@ static inline struct xfrm_dst *xfrm_alloc_dst(struct net *net, int family)
BUG();
}
xdst = dst_alloc(dst_ops, NULL, 0, 0, 0);
memset(&xdst->u.rt6.rt6i_table, 0, sizeof(*xdst) - sizeof(struct dst_entry));
xfrm_policy_put_afinfo(afinfo);

if (likely(xdst))
if (likely(xdst)) {
memset(&xdst->u.rt6.rt6i_table, 0,
sizeof(*xdst) - sizeof(struct dst_entry));
xdst->flo.ops = &xfrm_bundle_fc_ops;
else
} else
xdst = ERR_PTR(-ENOBUFS);

xfrm_policy_put_afinfo(afinfo);

return xdst;
}

Expand Down

0 comments on commit d4cae56

Please sign in to comment.