Skip to content

Commit

Permalink
drm/i915/selftests: fix a couple IS_ERR() vs NULL tests
Browse files Browse the repository at this point in the history
The shmem_pin_map() function doesn't return error pointers, it returns
NULL.

Fixes: be1cb55 ("drm/i915/gt: Keep a no-frills swappable copy of the default context state")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220708094104.GL2316@kadam
  • Loading branch information
Dan Carpenter authored and Matthew Auld committed Jul 11, 2022
1 parent 7835303 commit d50f5a1
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/gpu/drm/i915/gt/selftest_lrc.c
Original file line number Diff line number Diff line change
Expand Up @@ -176,8 +176,8 @@ static int live_lrc_layout(void *arg)
continue;

hw = shmem_pin_map(engine->default_state);
if (IS_ERR(hw)) {
err = PTR_ERR(hw);
if (!hw) {
err = -ENOMEM;
break;
}
hw += LRC_STATE_OFFSET / sizeof(*hw);
Expand Down Expand Up @@ -365,8 +365,8 @@ static int live_lrc_fixed(void *arg)
continue;

hw = shmem_pin_map(engine->default_state);
if (IS_ERR(hw)) {
err = PTR_ERR(hw);
if (!hw) {
err = -ENOMEM;
break;
}
hw += LRC_STATE_OFFSET / sizeof(*hw);
Expand Down

0 comments on commit d50f5a1

Please sign in to comment.