Skip to content

Commit

Permalink
extcon: Unify the dock device names on max8997/77693
Browse files Browse the repository at this point in the history
This patch change the name of various dock devices as 'DOCK' because the name of
various dock devices have not the standard naming rules. The name of dock devices
include the differenct word but it is ambiguous and never important information
on user-space aspect. This patch unifies the name of dock devices as following:
- Dock-Smart   -->|--> DOCK
- Dock-Desk    -->|
- Dock-Audio   -->|
- Dock-Card    -->|

Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
  • Loading branch information
Chanwoo Choi committed May 19, 2015
1 parent 41b3c01 commit d519c42
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 25 deletions.
31 changes: 13 additions & 18 deletions drivers/extcon/extcon-max77693.c
Original file line number Diff line number Diff line change
Expand Up @@ -210,9 +210,7 @@ enum {
EXTCON_CABLE_MHL,
EXTCON_CABLE_MHL_TA,
EXTCON_CABLE_JIG,
EXTCON_CABLE_DOCK_SMART,
EXTCON_CABLE_DOCK_DESK,
EXTCON_CABLE_DOCK_AUDIO,
EXTCON_CABLE_DOCK,

_EXTCON_CABLE_NUM,
};
Expand All @@ -227,9 +225,7 @@ static const char *max77693_extcon_cable[] = {
[EXTCON_CABLE_MHL] = "MHL",
[EXTCON_CABLE_MHL_TA] = "MHL-TA",
[EXTCON_CABLE_JIG] = "JIG",
[EXTCON_CABLE_DOCK_SMART] = "Dock-Smart",
[EXTCON_CABLE_DOCK_DESK] = "Dock-Desk",
[EXTCON_CABLE_DOCK_AUDIO] = "Dock-Audio",
[EXTCON_CABLE_DOCK] = "DOCK",

NULL,
};
Expand Down Expand Up @@ -501,15 +497,15 @@ static int max77693_muic_dock_handler(struct max77693_muic_info *info,
}

/*
* Notify Dock-Smart/MHL state.
* - Dock-Smart device include three type of cable which
* Notify Dock/MHL state.
* - Dock device include three type of cable which
* are HDMI, USB for mouse/keyboard and micro-usb port
* for USB/TA cable. Dock-Smart device need always exteranl
* power supply(USB/TA cable through micro-usb cable). Dock-
* Smart device support screen output of target to separate
* for USB/TA cable. Dock device need always exteranl
* power supply(USB/TA cable through micro-usb cable). Dock
* device support screen output of target to separate
* monitor and mouse/keyboard for desktop mode.
*
* Features of 'USB/TA cable with Dock-Smart device'
* Features of 'USB/TA cable with Dock device'
* - Support MHL
* - Support external output feature of audio
* - Support charging through micro-usb port without data
Expand All @@ -523,14 +519,14 @@ static int max77693_muic_dock_handler(struct max77693_muic_info *info,
if (ret < 0)
return ret;

extcon_set_cable_state(info->edev, "Dock-Smart", attached);
extcon_set_cable_state(info->edev, "DOCK", attached);
extcon_set_cable_state(info->edev, "MHL", attached);
goto out;
case MAX77693_MUIC_ADC_AUDIO_MODE_REMOTE: /* Dock-Desk */
strcpy(dock_name, "Dock-Desk");
strcpy(dock_name, "DOCK");
break;
case MAX77693_MUIC_ADC_AV_CABLE_NOLOAD: /* Dock-Audio */
strcpy(dock_name, "Dock-Audio");
strcpy(dock_name, "DOCK");
if (!attached)
extcon_set_cable_state(info->edev, "USB", false);
break;
Expand Down Expand Up @@ -847,7 +843,7 @@ static int max77693_muic_chg_handler(struct max77693_muic_info *info)
extcon_set_cable_state(info->edev, "USB", attached);

if (!cable_attached)
extcon_set_cable_state(info->edev, "Dock-Audio",
extcon_set_cable_state(info->edev, "DOCK",
cable_attached);
break;
case MAX77693_MUIC_ADC_RESERVED_ACC_3: /* Dock-Smart */
Expand Down Expand Up @@ -876,8 +872,7 @@ static int max77693_muic_chg_handler(struct max77693_muic_info *info)
if (ret < 0)
return ret;

extcon_set_cable_state(info->edev, "Dock-Smart",
attached);
extcon_set_cable_state(info->edev, "DOCK", attached);
extcon_set_cable_state(info->edev, "MHL", attached);

break;
Expand Down
10 changes: 3 additions & 7 deletions drivers/extcon/extcon-max8997.c
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,7 @@ enum {
EXTCON_CABLE_SLOW_CHARGER,
EXTCON_CABLE_CHARGE_DOWNSTREAM,
EXTCON_CABLE_MHL,
EXTCON_CABLE_DOCK_DESK,
EXTCON_CABLE_DOCK_CARD,
EXTCON_CABLE_DOCK,
EXTCON_CABLE_JIG,

_EXTCON_CABLE_NUM,
Expand All @@ -168,8 +167,7 @@ static const char *max8997_extcon_cable[] = {
[EXTCON_CABLE_SLOW_CHARGER] = "Slow-charger",
[EXTCON_CABLE_CHARGE_DOWNSTREAM] = "Charge-downstream",
[EXTCON_CABLE_MHL] = "MHL",
[EXTCON_CABLE_DOCK_DESK] = "Dock-Desk",
[EXTCON_CABLE_DOCK_CARD] = "Dock-Card",
[EXTCON_CABLE_DOCK] = "DOCK",
[EXTCON_CABLE_JIG] = "JIG",

NULL,
Expand Down Expand Up @@ -374,10 +372,8 @@ static int max8997_muic_handle_dock(struct max8997_muic_info *info,

switch (cable_type) {
case MAX8997_MUIC_ADC_AV_CABLE_NOLOAD:
extcon_set_cable_state(info->edev, "Dock-desk", attached);
break;
case MAX8997_MUIC_ADC_FACTORY_MODE_UART_ON:
extcon_set_cable_state(info->edev, "Dock-card", attached);
extcon_set_cable_state(info->edev, "DOCK", attached);
break;
default:
dev_err(info->dev, "failed to detect %s dock device\n",
Expand Down

0 comments on commit d519c42

Please sign in to comment.