Skip to content

Commit

Permalink
Staging: hv: util: Deal with driver register failures
Browse files Browse the repository at this point in the history
Properly deal with vmbus_driver_register() failures.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
K. Y. Srinivasan authored and Greg Kroah-Hartman committed Sep 6, 2011
1 parent 06b3f44 commit d531bab
Showing 1 changed file with 16 additions and 5 deletions.
21 changes: 16 additions & 5 deletions drivers/staging/hv/hv_util.c
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,7 @@ static struct hv_driver util_drv = {

static int __init init_hyperv_utils(void)
{
int ret;
pr_info("Registering HyperV Utility Driver\n");

if (hv_kvp_init())
Expand All @@ -289,12 +290,15 @@ static int __init init_hyperv_utils(void)

if (!shut_txf_buf || !time_txf_buf || !hbeat_txf_buf) {
pr_info("Unable to allocate memory for receive buffer\n");
kfree(shut_txf_buf);
kfree(time_txf_buf);
kfree(hbeat_txf_buf);
return -ENOMEM;
ret = -ENOMEM;
goto err;
}

ret = vmbus_driver_register(&util_drv);

if (ret != 0)
goto err;

hv_cb_utils[HV_SHUTDOWN_MSG].callback = &shutdown_onchannelcallback;

hv_cb_utils[HV_TIMESYNC_MSG].callback = &timesync_onchannelcallback;
Expand All @@ -303,7 +307,14 @@ static int __init init_hyperv_utils(void)

hv_cb_utils[HV_KVP_MSG].callback = &hv_kvp_onchannelcallback;

return vmbus_driver_register(&util_drv);
return 0;

err:
kfree(shut_txf_buf);
kfree(time_txf_buf);
kfree(hbeat_txf_buf);

return ret;
}

static void exit_hyperv_utils(void)
Expand Down

0 comments on commit d531bab

Please sign in to comment.