Skip to content

Commit

Permalink
USB: serial generic resume function fix
Browse files Browse the repository at this point in the history
This removes an unnecessary check for autoresume from the generic
resume method. The check has been obsoleted by the now delayed
increase of the usage counter which makes the error this check prevented
impossible. This change allows drivers which only use the bulk read URB
the use of the generic method even if they support autosuspend.

Signed-off-by: Oliver Neukum <oneukum@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Oliver Neukum authored and Greg Kroah-Hartman committed Mar 24, 2009
1 parent f8bece8 commit d55c0ae
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions drivers/usb/serial/generic.c
Original file line number Diff line number Diff line change
Expand Up @@ -177,14 +177,6 @@ int usb_serial_generic_resume(struct usb_serial *serial)
struct usb_serial_port *port;
int i, c = 0, r;

#ifdef CONFIG_PM
/*
* If this is an autoresume, don't submit URBs.
* They will be submitted in the open function instead.
*/
if (serial->dev->auto_pm)
return 0;
#endif
for (i = 0; i < serial->num_ports; i++) {
port = serial->port[i];
if (port->port.count && port->read_urb) {
Expand Down

0 comments on commit d55c0ae

Please sign in to comment.