Skip to content

Commit

Permalink
S3C2410: add error print if we cannot add attribute
Browse files Browse the repository at this point in the history
Fix the following warning by checking the result of device_create_file and
printing an error but not removing the device (loss of debug registers is
not fatal).

drivers/video/s3c2410fb.c:905: warning: ignoring return value of 'device_create_file', declared with attribute warn_unused_result

Signed-off-by: Ben Dooks <ben-linux@fluff.org>
Cc: Arnaud Patard <arnaud.patard@rtp-net.org>
Acked-by: Krzysztof Helt <krzysztof.h1@wp.pl>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Ben Dooks authored and Linus Torvalds committed May 24, 2008
1 parent 673b460 commit d585dfe
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion drivers/video/s3c2410fb.c
Original file line number Diff line number Diff line change
Expand Up @@ -972,7 +972,10 @@ static int __init s3c24xxfb_probe(struct platform_device *pdev,
}

/* create device files */
device_create_file(&pdev->dev, &dev_attr_debug);
ret = device_create_file(&pdev->dev, &dev_attr_debug);
if (ret) {
printk(KERN_ERR "failed to add debug attribute\n");
}

printk(KERN_INFO "fb%d: %s frame buffer device\n",
fbinfo->node, fbinfo->fix.id);
Expand Down

0 comments on commit d585dfe

Please sign in to comment.