Skip to content

Commit

Permalink
samples: bpf: fix: seg fault with NULL pointer arg
Browse files Browse the repository at this point in the history
When NULL pointer accidentally passed to write_kprobe_events,
due to strlen(NULL), segmentation fault happens.
Changed code returns -1 to deal with this situation.

Bug issued with Smatch, static analysis.

Signed-off-by: Daniel T. Lee <danieltimlee@gmail.com>
Acked-by: Song Liu <songliubraving@fb.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
  • Loading branch information
Daniel T. Lee authored and Daniel Borkmann committed Dec 3, 2018
1 parent 90b1023 commit d59dd69
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion samples/bpf/bpf_load.c
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ static int write_kprobe_events(const char *val)
{
int fd, ret, flags;

if ((val != NULL) && (val[0] == '\0'))
if (val == NULL)
return -1;
else if (val[0] == '\0')
flags = O_WRONLY | O_TRUNC;
else
flags = O_WRONLY | O_APPEND;
Expand Down

0 comments on commit d59dd69

Please sign in to comment.