Skip to content

Commit

Permalink
sched: Fix idle balancing
Browse files Browse the repository at this point in the history
An earlier commit reverts idle balancing throttling reset to fix a 30%
regression in volanomark throughput. We still need to reset idle_stamp
when we pull a task in newidle balance.

Reported-by: Alex Shi <alex.shi@intel.com>
Signed-off-by: Nikhil Rao <ncrao@google.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <1290022924-3548-1-git-send-email-ncrao@google.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Nikhil Rao authored and Ingo Molnar committed Nov 18, 2010
1 parent b5482cf commit d5ad140
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion kernel/sched_fair.c
Original file line number Diff line number Diff line change
Expand Up @@ -3215,8 +3215,10 @@ static void idle_balance(int this_cpu, struct rq *this_rq)
interval = msecs_to_jiffies(sd->balance_interval);
if (time_after(next_balance, sd->last_balance + interval))
next_balance = sd->last_balance + interval;
if (pulled_task)
if (pulled_task) {
this_rq->idle_stamp = 0;
break;
}
}

raw_spin_lock(&this_rq->lock);
Expand Down

0 comments on commit d5ad140

Please sign in to comment.