Skip to content

Commit

Permalink
target: remove the t_se_count field in struct se_cmd
Browse files Browse the repository at this point in the history
Now that tasks are gone we are guaranteed to only get a single completion
per command, and thus don't need this counter.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
  • Loading branch information
Christoph Hellwig authored and Nicholas Bellinger committed May 6, 2012
1 parent d43d6ae commit d5dc28e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
6 changes: 0 additions & 6 deletions drivers/target/target_core_transport.c
Original file line number Diff line number Diff line change
Expand Up @@ -3284,11 +3284,6 @@ static void transport_put_cmd(struct se_cmd *cmd)
goto out_busy;
}

if (atomic_read(&cmd->t_se_count)) {
if (!atomic_dec_and_test(&cmd->t_se_count))
goto out_busy;
}

if (cmd->transport_state & CMD_T_DEV_ACTIVE) {
cmd->transport_state &= ~CMD_T_DEV_ACTIVE;
target_remove_from_state_list(cmd);
Expand Down Expand Up @@ -3498,7 +3493,6 @@ int transport_generic_new_cmd(struct se_cmd *cmd)
}

atomic_inc(&cmd->t_fe_count);
atomic_inc(&cmd->t_se_count);

/*
* For WRITEs, let the fabric know its buffer is ready.
Expand Down
1 change: 0 additions & 1 deletion include/target/target_core_base.h
Original file line number Diff line number Diff line change
Expand Up @@ -548,7 +548,6 @@ struct se_cmd {
unsigned char __t_task_cdb[TCM_MAX_COMMAND_SIZE];
unsigned long long t_task_lba;
atomic_t t_fe_count;
atomic_t t_se_count;
unsigned int transport_state;
#define CMD_T_ABORTED (1 << 0)
#define CMD_T_ACTIVE (1 << 1)
Expand Down

0 comments on commit d5dc28e

Please sign in to comment.