Skip to content

Commit

Permalink
RDMA/ocrdma: Remove redundant check in ocrdma_build_fr()
Browse files Browse the repository at this point in the history
Remove the redundant check of comparing if a 32-bit value is greater
than 0xffffffffULL.

Reported by Dan Carpenter.

Signed-off-by: Naresh Gottumukkala <bgottumukkala@emulex.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
  • Loading branch information
Naresh Gottumukkala authored and Roland Dreier committed Nov 8, 2013
1 parent 1852d1d commit d5e3f37
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
Original file line number Diff line number Diff line change
Expand Up @@ -1981,9 +1981,7 @@ static int ocrdma_build_fr(struct ocrdma_qp *qp, struct ocrdma_hdr_wqe *hdr,

wqe_size = roundup(wqe_size, OCRDMA_WQE_ALIGN_BYTES);

if ((wr->wr.fast_reg.page_list_len >
qp->dev->attr.max_pages_per_frmr) ||
(wr->wr.fast_reg.length > 0xffffffffULL))
if (wr->wr.fast_reg.page_list_len > qp->dev->attr.max_pages_per_frmr)
return -EINVAL;

hdr->cw |= (OCRDMA_FR_MR << OCRDMA_WQE_OPCODE_SHIFT);
Expand Down

0 comments on commit d5e3f37

Please sign in to comment.