Skip to content

Commit

Permalink
kbuild: fix LOCALVERSION handling to match description
Browse files Browse the repository at this point in the history
In the commit below the version string handling was modified, adding
a '+' where no other version information was supplied:

    commit 85a256d
    Author: David Rientjes <rientjes@google.com>
    Date:   Wed Jan 13 13:01:05 2010 -0800

From the commit the intent was as below:

     - when CONFIG_LOCALVERSION_AUTO is disabled, a `+' is appended if the
       repository has been revised beyond a tagged commit and LOCALVERSION=
       was not passed to "make".

However if the user supplies an empty LOCALVERSION on the command line
the plus suffix is still added.  This form is useful in the case where
the build environment knows that the version as specified is correct and
complete but does not correspond to a specific tag.

This patch changes the implementation to match the documentation
such that specifying LOCALVERSION= on the build line is sufficient
to suppress any suffix.

Signed-off-by: Andy Whitcroft <apw@canonical.com>
Acked-by: David Rientjes <rientjes@google.com>
Signed-off-by: Michal Marek <mmarek@suse.cz>
  • Loading branch information
Andy Whitcroft authored and Michal Marek committed Jun 15, 2010
1 parent 1c93866 commit d5eda75
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -944,7 +944,7 @@ ifdef CONFIG_LOCALVERSION_AUTO
localver-extra = $(scm-identifier)
else
ifneq ($(scm-identifier),)
ifeq ($(LOCALVERSION),)
ifeq ("$(origin LOCALVERSION)", "undefined")
localver-extra = +
endif
endif
Expand Down

0 comments on commit d5eda75

Please sign in to comment.