Skip to content

Commit

Permalink
IIO: ADC: fix return value check in stm32_dfsdm_adc_probe()
Browse files Browse the repository at this point in the history
In case of error, the function devm_iio_device_alloc() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.

Fixes: e2e6771 ("IIO: ADC: add STM32 DFSDM sigma delta ADC support")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Wei Yongjun authored and Mark Brown committed Jan 11, 2018
1 parent 2514071 commit d5ff18b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/iio/adc/stm32-dfsdm-adc.c
Original file line number Diff line number Diff line change
Expand Up @@ -1100,9 +1100,9 @@ static int stm32_dfsdm_adc_probe(struct platform_device *pdev)
dev_data = (const struct stm32_dfsdm_dev_data *)of_id->data;

iio = devm_iio_device_alloc(dev, sizeof(*adc));
if (IS_ERR(iio)) {
if (!iio) {
dev_err(dev, "%s: Failed to allocate IIO\n", __func__);
return PTR_ERR(iio);
return -ENOMEM;
}

adc = iio_priv(iio);
Expand Down

0 comments on commit d5ff18b

Please sign in to comment.