Skip to content

Commit

Permalink
x86, nops: Missing break resulting in incorrect selection on Intel
Browse files Browse the repository at this point in the history
The Intel case falls through into the generic case which then changes
the values.  For cases like the P6 it doesn't do the right thing so
this seems to be a screwup.

Signed-off-by: Alan Cox <alan@linux.intel.com>
Link: http://lkml.kernel.org/n/tip-lww2uirad4skzjlmrm0vru8o@git.kernel.org
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Cc: <stable@vger.kernel.org>
  • Loading branch information
Alan Cox authored and H. Peter Anvin committed Jul 25, 2012
1 parent 2a8ac74 commit d6250a3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/x86/kernel/alternative.c
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ void __init arch_init_ideal_nops(void)
ideal_nops = intel_nops;
#endif
}

break;
default:
#ifdef CONFIG_X86_64
ideal_nops = k8_nops;
Expand Down

0 comments on commit d6250a3

Please sign in to comment.