Skip to content

Commit

Permalink
kbuild: Fix Propeller build option
Browse files Browse the repository at this point in the history
The '-fbasic-block-sections=labels' option has been deprecated in tip
of tree clang (20.0.0) [1]. While the option still works, a warning is
emitted:

  clang: warning: argument '-fbasic-block-sections=labels' is deprecated, use '-fbasic-block-address-map' instead [-Wdeprecated]

Add a version check to set the proper option.

Link: https://github.com/llvm/llvm-project/pull/110039 [1]

Signed-off-by: Rong Xu <xur@google.com>
Reported-by: Nathan Chancellor <nathan@kernel.org>
Suggested-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
  • Loading branch information
Rong Xu authored and Masahiro Yamada committed Nov 27, 2024
1 parent d5dc958 commit d63b852
Showing 1 changed file with 13 additions and 2 deletions.
15 changes: 13 additions & 2 deletions scripts/Makefile.propeller
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,14 @@ ifdef CLANG_PROPELLER_PROFILE_PREFIX
CFLAGS_PROPELLER_CLANG := -fbasic-block-sections=list=$(CLANG_PROPELLER_PROFILE_PREFIX)_cc_profile.txt -ffunction-sections
KBUILD_LDFLAGS += --symbol-ordering-file=$(CLANG_PROPELLER_PROFILE_PREFIX)_ld_profile.txt --no-warn-symbol-ordering
else
CFLAGS_PROPELLER_CLANG := -fbasic-block-sections=labels
# Starting with Clang v20, the '-fbasic-block-sections=labels' option is
# deprecated. Use the recommended '-fbasic-block-address-map' option.
# Link: https://github.com/llvm/llvm-project/pull/110039
ifeq ($(call clang-min-version, 200000),y)
CFLAGS_PROPELLER_CLANG := -fbasic-block-address-map
else
CFLAGS_PROPELLER_CLANG := -fbasic-block-sections=labels
endif
endif

# Propeller requires debug information to embed module names in the profiles.
Expand All @@ -21,7 +28,11 @@ ifdef CONFIG_LTO_CLANG_THIN
ifdef CLANG_PROPELLER_PROFILE_PREFIX
KBUILD_LDFLAGS += --lto-basic-block-sections=$(CLANG_PROPELLER_PROFILE_PREFIX)_cc_profile.txt
else
KBUILD_LDFLAGS += --lto-basic-block-sections=labels
ifeq ($(call test-ge, $(CONFIG_LLD_VERSION), 200000),y)
KBUILD_LDFLAGS += --lto-basic-block-address-map
else
KBUILD_LDFLAGS += --lto-basic-block-sections=labels
endif
endif
endif

Expand Down

0 comments on commit d63b852

Please sign in to comment.