Skip to content

Commit

Permalink
net: dsa: sja1105: remove redundant re-assignment of pointer table
Browse files Browse the repository at this point in the history
The pointer table is being re-assigned with a value that is never
read. The assignment is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Colin Ian King authored and David S. Miller committed Jul 26, 2021
1 parent ee80dd2 commit d63f887
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/net/dsa/sja1105/sja1105_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -2163,8 +2163,6 @@ static int sja1105_build_vlan_table(struct sja1105_private *priv)
if (!new_vlan)
return -ENOMEM;

table = &priv->static_config.tables[BLK_IDX_VLAN_LOOKUP];

for (i = 0; i < VLAN_N_VID; i++)
new_vlan[i].vlanid = VLAN_N_VID;

Expand Down

0 comments on commit d63f887

Please sign in to comment.