Skip to content

Commit

Permalink
iommu/vt-d: Split iommu_prepare_identity_map
Browse files Browse the repository at this point in the history
Split the part of the function that fetches the domain out
and put the rest into into a domain_prepare_identity_map, so
that the code can also be used with when the domain is
already known.

Signed-off-by: Joerg Roedel <jroedel@suse.de>
  • Loading branch information
Joerg Roedel committed Oct 5, 2015
1 parent 9ffecb1 commit d66ce54
Showing 1 changed file with 22 additions and 20 deletions.
42 changes: 22 additions & 20 deletions drivers/iommu/intel-iommu.c
Original file line number Diff line number Diff line change
Expand Up @@ -2429,17 +2429,11 @@ static int iommu_domain_identity_map(struct dmar_domain *domain,
DMA_PTE_READ|DMA_PTE_WRITE);
}

static int iommu_prepare_identity_map(struct device *dev,
unsigned long long start,
unsigned long long end)
static int domain_prepare_identity_map(struct device *dev,
struct dmar_domain *domain,
unsigned long long start,
unsigned long long end)
{
struct dmar_domain *domain;
int ret;

domain = get_domain_for_dev(dev, DEFAULT_DOMAIN_ADDRESS_WIDTH);
if (!domain)
return -ENOMEM;

/* For _hardware_ passthrough, don't bother. But for software
passthrough, we do it anyway -- it may indicate a memory
range which is reserved in E820, so which didn't get set
Expand All @@ -2459,8 +2453,7 @@ static int iommu_prepare_identity_map(struct device *dev,
dmi_get_system_info(DMI_BIOS_VENDOR),
dmi_get_system_info(DMI_BIOS_VERSION),
dmi_get_system_info(DMI_PRODUCT_VERSION));
ret = -EIO;
goto error;
return -EIO;
}

if (end >> agaw_to_width(domain->agaw)) {
Expand All @@ -2470,18 +2463,27 @@ static int iommu_prepare_identity_map(struct device *dev,
dmi_get_system_info(DMI_BIOS_VENDOR),
dmi_get_system_info(DMI_BIOS_VERSION),
dmi_get_system_info(DMI_PRODUCT_VERSION));
ret = -EIO;
goto error;
return -EIO;
}

ret = iommu_domain_identity_map(domain, start, end);
if (ret)
goto error;
return iommu_domain_identity_map(domain, start, end);
}

return 0;
static int iommu_prepare_identity_map(struct device *dev,
unsigned long long start,
unsigned long long end)
{
struct dmar_domain *domain;
int ret;

domain = get_domain_for_dev(dev, DEFAULT_DOMAIN_ADDRESS_WIDTH);
if (!domain)
return -ENOMEM;

ret = domain_prepare_identity_map(dev, domain, start, end);
if (ret)
domain_exit(domain);

error:
domain_exit(domain);
return ret;
}

Expand Down

0 comments on commit d66ce54

Please sign in to comment.