Skip to content

Commit

Permalink
omapdrm: dss: mark runtime PM functions __maybe_unused
Browse files Browse the repository at this point in the history
Using the SET_RUNTIME_PM_OPS() macro causes a warning about the
referenced functions when they are marked static but not __maybe_unused:

drivers/gpu/drm/omapdrm/dss/dss.c:1572:12: error: unused function 'dss_runtime_suspend' [-Werror,-Wunused-function]
drivers/gpu/drm/omapdrm/dss/dss.c:1584:12: error: unused function 'dss_runtime_resume' [-Werror,-Wunused-function]
drivers/gpu/drm/omapdrm/dss/dispc.c:4845:12: error: unused function 'dispc_runtime_suspend' [-Werror,-Wunused-function]
drivers/gpu/drm/omapdrm/dss/dispc.c:4860:12: error: unused function 'dispc_runtime_resume' [-Werror,-Wunused-function]

Fixes: b92f7ea ("drm/omap: dss: Make use of the helper macro SET_RUNTIME_PM_OPS()")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20211205131612.3192652-1-arnd@kernel.org
  • Loading branch information
Arnd Bergmann authored and Tomi Valkeinen committed Dec 8, 2021
1 parent e02b5cc commit d6c75c2
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions drivers/gpu/drm/omapdrm/dss/dispc.c
Original file line number Diff line number Diff line change
Expand Up @@ -4869,7 +4869,7 @@ static int dispc_remove(struct platform_device *pdev)
return 0;
}

static int dispc_runtime_suspend(struct device *dev)
static __maybe_unused int dispc_runtime_suspend(struct device *dev)
{
struct dispc_device *dispc = dev_get_drvdata(dev);

Expand All @@ -4884,7 +4884,7 @@ static int dispc_runtime_suspend(struct device *dev)
return 0;
}

static int dispc_runtime_resume(struct device *dev)
static __maybe_unused int dispc_runtime_resume(struct device *dev)
{
struct dispc_device *dispc = dev_get_drvdata(dev);

Expand Down
4 changes: 2 additions & 2 deletions drivers/gpu/drm/omapdrm/dss/dsi.c
Original file line number Diff line number Diff line change
Expand Up @@ -5058,7 +5058,7 @@ static int dsi_remove(struct platform_device *pdev)
return 0;
}

static int dsi_runtime_suspend(struct device *dev)
static __maybe_unused int dsi_runtime_suspend(struct device *dev)
{
struct dsi_data *dsi = dev_get_drvdata(dev);

Expand All @@ -5071,7 +5071,7 @@ static int dsi_runtime_suspend(struct device *dev)
return 0;
}

static int dsi_runtime_resume(struct device *dev)
static __maybe_unused int dsi_runtime_resume(struct device *dev)
{
struct dsi_data *dsi = dev_get_drvdata(dev);

Expand Down
4 changes: 2 additions & 2 deletions drivers/gpu/drm/omapdrm/dss/dss.c
Original file line number Diff line number Diff line change
Expand Up @@ -1569,7 +1569,7 @@ static void dss_shutdown(struct platform_device *pdev)
DSSDBG("shutdown\n");
}

static int dss_runtime_suspend(struct device *dev)
static __maybe_unused int dss_runtime_suspend(struct device *dev)
{
struct dss_device *dss = dev_get_drvdata(dev);

Expand All @@ -1581,7 +1581,7 @@ static int dss_runtime_suspend(struct device *dev)
return 0;
}

static int dss_runtime_resume(struct device *dev)
static __maybe_unused int dss_runtime_resume(struct device *dev)
{
struct dss_device *dss = dev_get_drvdata(dev);
int r;
Expand Down
4 changes: 2 additions & 2 deletions drivers/gpu/drm/omapdrm/dss/venc.c
Original file line number Diff line number Diff line change
Expand Up @@ -879,7 +879,7 @@ static int venc_remove(struct platform_device *pdev)
return 0;
}

static int venc_runtime_suspend(struct device *dev)
static __maybe_unused int venc_runtime_suspend(struct device *dev)
{
struct venc_device *venc = dev_get_drvdata(dev);

Expand All @@ -889,7 +889,7 @@ static int venc_runtime_suspend(struct device *dev)
return 0;
}

static int venc_runtime_resume(struct device *dev)
static __maybe_unused int venc_runtime_resume(struct device *dev)
{
struct venc_device *venc = dev_get_drvdata(dev);

Expand Down

0 comments on commit d6c75c2

Please sign in to comment.