Skip to content

Commit

Permalink
Merge tag 'tty-3.7-rc5' of git://git.kernel.org/pub/scm/linux/kernel/…
Browse files Browse the repository at this point in the history
…git/gregkh/tty

Pull TTY fixes from Greg Kroah-Hartman:
 "Here are two TTY driver fixes for 3.7-rc5.

  They resolve a bug in the hvc driver that has been reported, and fix a
  problem with the list of device ids in the max310x serial driver.

  Both have been in linux-next for a while.

  Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>"

* tag 'tty-3.7-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty:
  tty: serial: max310x: Add terminating entry for spi_device_id table
  TTY: hvc_console, fix port reference count going to zero prematurely
  • Loading branch information
Linus Torvalds committed Nov 16, 2012
2 parents 7e11156 + 1838b8c commit d6ee1a2
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
7 changes: 0 additions & 7 deletions drivers/tty/hvc/hvc_console.c
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,6 @@ static void hvc_hangup(struct tty_struct *tty)
{
struct hvc_struct *hp = tty->driver_data;
unsigned long flags;
int temp_open_count;

if (!hp)
return;
Expand All @@ -444,7 +443,6 @@ static void hvc_hangup(struct tty_struct *tty)
return;
}

temp_open_count = hp->port.count;
hp->port.count = 0;
spin_unlock_irqrestore(&hp->port.lock, flags);
tty_port_tty_set(&hp->port, NULL);
Expand All @@ -453,11 +451,6 @@ static void hvc_hangup(struct tty_struct *tty)

if (hp->ops->notifier_hangup)
hp->ops->notifier_hangup(hp, hp->data);

while(temp_open_count) {
--temp_open_count;
tty_port_put(&hp->port);
}
}

/*
Expand Down
1 change: 1 addition & 0 deletions drivers/tty/serial/max310x.c
Original file line number Diff line number Diff line change
Expand Up @@ -1239,6 +1239,7 @@ static int __devexit max310x_remove(struct spi_device *spi)
static const struct spi_device_id max310x_id_table[] = {
{ "max3107", MAX310X_TYPE_MAX3107 },
{ "max3108", MAX310X_TYPE_MAX3108 },
{ }
};
MODULE_DEVICE_TABLE(spi, max310x_id_table);

Expand Down

0 comments on commit d6ee1a2

Please sign in to comment.