Skip to content

Commit

Permalink
TPM: remove unnecessary little endian conversion
Browse files Browse the repository at this point in the history
The base pointer for the event log is allocated in the local
kernel (in prom_instantiate_sml()), therefore it is already in
the host's endian byte order and requires no conversion.

The content of the 'basep' pointer in read_log() stores the
base address of the log. This patch ensures that it is correctly
implemented.

Signed-off-by: Hon Ching(Vicky) Lo <honclo@linux.vnet.ibm.com>
Signed-off-by: Joy Latten <jmlatten@linux.vnet.ibm.com>
Reviewed-by: Ashley Lai <ashley@ahsleylai.com>
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
  • Loading branch information
Hon Ching \(Vicky\) Lo authored and Peter Huewe committed Oct 18, 2015
1 parent 0cc698a commit d72c391
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/char/tpm/tpm_of.c
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ int read_log(struct tpm_bios_log *log)
{
struct device_node *np;
const u32 *sizep;
const __be64 *basep;
const u64 *basep;

if (log->bios_event_log != NULL) {
pr_err("%s: ERROR - Eventlog already initialized\n", __func__);
Expand Down Expand Up @@ -63,7 +63,7 @@ int read_log(struct tpm_bios_log *log)

log->bios_event_log_end = log->bios_event_log + *sizep;

memcpy(log->bios_event_log, __va(be64_to_cpup(basep)), *sizep);
memcpy(log->bios_event_log, __va(*basep), *sizep);

return 0;

Expand Down

0 comments on commit d72c391

Please sign in to comment.