Skip to content

Commit

Permalink
Bluetooth: Disconnect connected devices before rfkilling adapter
Browse files Browse the repository at this point in the history
On a lot of platforms (at least the MS Surface devices, M1 macbooks, and
a few ThinkPads) firmware doesn't do its job when rfkilling a device
and the bluetooth adapter is not actually shut down properly on rfkill.
This leads to connected devices remaining in connected state and the
bluetooth connection eventually timing out after rfkilling an adapter.

Use the rfkill hook in the HCI driver to go through the full power-off
sequence (including stopping scans and disconnecting devices) before
rfkilling it, just like MGMT_OP_SET_POWERED would do.

In case anything during the larger power-off sequence fails, make sure
the device is still closed and the rfkill ends up being effective in
the end.

Signed-off-by: Jonas Dreßler <verdre@v0yd.nl>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
  • Loading branch information
Jonas Dreßler authored and Luiz Augusto von Dentz committed Mar 6, 2024
1 parent b14202a commit d77433c
Showing 1 changed file with 33 additions and 2 deletions.
35 changes: 33 additions & 2 deletions net/bluetooth/hci_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -940,20 +940,51 @@ int hci_get_dev_info(void __user *arg)

/* ---- Interface to HCI drivers ---- */

static int hci_dev_do_poweroff(struct hci_dev *hdev)
{
int err;

BT_DBG("%s %p", hdev->name, hdev);

hci_req_sync_lock(hdev);

err = hci_set_powered_sync(hdev, false);

hci_req_sync_unlock(hdev);

return err;
}

static int hci_rfkill_set_block(void *data, bool blocked)
{
struct hci_dev *hdev = data;
int err;

BT_DBG("%p name %s blocked %d", hdev, hdev->name, blocked);

if (hci_dev_test_flag(hdev, HCI_USER_CHANNEL))
return -EBUSY;

if (blocked == hci_dev_test_flag(hdev, HCI_RFKILLED))
return 0;

if (blocked) {
hci_dev_set_flag(hdev, HCI_RFKILLED);

if (!hci_dev_test_flag(hdev, HCI_SETUP) &&
!hci_dev_test_flag(hdev, HCI_CONFIG))
hci_dev_do_close(hdev);
!hci_dev_test_flag(hdev, HCI_CONFIG)) {
err = hci_dev_do_poweroff(hdev);
if (err) {
bt_dev_err(hdev, "Error when powering off device on rfkill (%d)",
err);

/* Make sure the device is still closed even if
* anything during power off sequence (eg.
* disconnecting devices) failed.
*/
hci_dev_do_close(hdev);
}
}
} else {
hci_dev_clear_flag(hdev, HCI_RFKILLED);
}
Expand Down

0 comments on commit d77433c

Please sign in to comment.