Skip to content

Commit

Permalink
drm/xe: clear the serviced bits on INTR_IDENTITY_REG
Browse files Browse the repository at this point in the history
The spec for this register, like many other interrupt related ones,
asks software to write back '1' to clear the serviced bits. Let's
respect the spec.

v2:
- Update commit message
- Add missing CC

Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
CC: Daniele Spurio Ceraolo <daniele.ceraolospurio@intel.com>
CC: Lucas De Marchi <lucas.demarchi@intel.com>
CC: Rodrigo Vivi <rodrigo.vivi@intel.com>
CC: Paulo Zanoni <paulo.r.zanoni@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
  • Loading branch information
Jonathan Cavitt authored and Rodrigo Vivi committed Dec 21, 2023
1 parent 37d1eaa commit d7925d0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/xe/xe_irq.c
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ gt_engine_identity(struct xe_device *xe,
return 0;
}

xe_mmio_write32(mmio, INTR_IDENTITY_REG(bank), INTR_DATA_VALID);
xe_mmio_write32(mmio, INTR_IDENTITY_REG(bank), ident);

return ident;
}
Expand Down

0 comments on commit d7925d0

Please sign in to comment.