Skip to content

Commit

Permalink
mkiss: Fix use after free in mkiss_close().
Browse files Browse the repository at this point in the history
Need to do the unregister_device() after all references to the driver
private have been done.

Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David Miller committed Dec 18, 2015
1 parent acf673a commit d79f16c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/net/hamradio/mkiss.c
Original file line number Diff line number Diff line change
Expand Up @@ -798,13 +798,13 @@ static void mkiss_close(struct tty_struct *tty)
if (!atomic_dec_and_test(&ax->refcnt))
down(&ax->dead_sem);

unregister_netdev(ax->dev);

/* Free all AX25 frame buffers. */
kfree(ax->rbuff);
kfree(ax->xbuff);

ax->tty = NULL;

unregister_netdev(ax->dev);
}

/* Perform I/O control on an active ax25 channel. */
Expand Down

0 comments on commit d79f16c

Please sign in to comment.