Skip to content

Commit

Permalink
ACPI: processor: driver doesn't need to evaluate _PDC
Browse files Browse the repository at this point in the history
Now that the early _PDC evaluation path knows how to correctly
evaluate _PDC on only physically present processors, there's no
need for the processor driver to evaluate it later when it loads.

To cover the hotplug case, push _PDC evaluation down into the
hotplug paths.

Cc: x86@kernel.org
Cc: Tony Luck <tony.luck@intel.com>
Acked-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Signed-off-by: Alex Chiang <achiang@hp.com>
Signed-off-by: Len Brown <len.brown@intel.com>
  • Loading branch information
Alex Chiang authored and Len Brown committed Mar 15, 2010
1 parent 3b1da4c commit d8191fa
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 10 deletions.
3 changes: 3 additions & 0 deletions arch/ia64/kernel/acpi.c
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
#include <linux/efi.h>
#include <linux/mmzone.h>
#include <linux/nodemask.h>
#include <acpi/processor.h>
#include <asm/io.h>
#include <asm/iosapic.h>
#include <asm/machvec.h>
Expand Down Expand Up @@ -907,6 +908,8 @@ int acpi_map_lsapic(acpi_handle handle, int *pcpu)
cpu_set(cpu, cpu_present_map);
ia64_cpu_to_sapicid[cpu] = physid;

acpi_processor_set_pdc(handle);

*pcpu = cpu;
return (0);
}
Expand Down
3 changes: 3 additions & 0 deletions arch/x86/kernel/acpi/boot.c
Original file line number Diff line number Diff line change
Expand Up @@ -490,6 +490,7 @@ int acpi_register_gsi(struct device *dev, u32 gsi, int trigger, int polarity)
* ACPI based hotplug support for CPU
*/
#ifdef CONFIG_ACPI_HOTPLUG_CPU
#include <acpi/processor.h>

static void acpi_map_cpu2node(acpi_handle handle, int cpu, int physid)
{
Expand Down Expand Up @@ -567,6 +568,8 @@ static int __cpuinit _acpi_map_lsapic(acpi_handle handle, int *pcpu)
goto free_new_map;
}

acpi_processor_set_pdc(handle);

cpu = cpumask_first(new_map);
acpi_map_cpu2node(handle, cpu, physid);

Expand Down
7 changes: 0 additions & 7 deletions drivers/acpi/processor_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -317,18 +317,13 @@ acpi_processor_eval_pdc(acpi_handle handle, struct acpi_object_list *pdc_in)
return status;
}

static int early_pdc_done;

void acpi_processor_set_pdc(acpi_handle handle)
{
struct acpi_object_list *obj_list;

if (arch_has_acpi_pdc() == false)
return;

if (early_pdc_done)
return;

obj_list = acpi_processor_alloc_pdc();
if (!obj_list)
return;
Expand Down Expand Up @@ -369,6 +364,4 @@ void __init acpi_early_processor_set_pdc(void)
acpi_walk_namespace(ACPI_TYPE_PROCESSOR, ACPI_ROOT_OBJECT,
ACPI_UINT32_MAX,
early_init_pdc, NULL, NULL, NULL);

early_pdc_done = 1;
}
3 changes: 0 additions & 3 deletions drivers/acpi/processor_driver.c
Original file line number Diff line number Diff line change
Expand Up @@ -608,9 +608,6 @@ static int __cpuinit acpi_processor_add(struct acpi_device *device)
goto err_remove_fs;
}

/* _PDC call should be done before doing anything else (if reqd.). */
acpi_processor_set_pdc(pr->handle);

#ifdef CONFIG_CPU_FREQ
acpi_processor_ppc_has_changed(pr, 0);
#endif
Expand Down

0 comments on commit d8191fa

Please sign in to comment.