Skip to content

Commit

Permalink
ubsan: no need to unset panic_on_warn in ubsan_epilogue()
Browse files Browse the repository at this point in the history
panic_on_warn is unset inside panic(), so no need to unset it before
calling panic() in ubsan_epilogue().

Link: https://lkml.kernel.org/r/1644324666-15947-5-git-send-email-yangtiezhu@loongson.cn
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Reviewed-by: Marco Elver <elver@google.com>
Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com>
Cc: Baoquan He <bhe@redhat.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Xuefeng Li <lixuefeng@loongson.cn>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Tiezhu Yang authored and Linus Torvalds committed Mar 24, 2022
1 parent 1a2383e commit d83ce02
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions lib/ubsan.c
Original file line number Diff line number Diff line change
Expand Up @@ -154,16 +154,8 @@ static void ubsan_epilogue(void)

current->in_ubsan--;

if (panic_on_warn) {
/*
* This thread may hit another WARN() in the panic path.
* Resetting this prevents additional WARN() from panicking the
* system on this thread. Other threads are blocked by the
* panic_mutex in panic().
*/
panic_on_warn = 0;
if (panic_on_warn)
panic("panic_on_warn set ...\n");
}
}

void __ubsan_handle_divrem_overflow(void *_data, void *lhs, void *rhs)
Expand Down

0 comments on commit d83ce02

Please sign in to comment.