Skip to content

Commit

Permalink
mfd: kempld-core: Simplify function return logic
Browse files Browse the repository at this point in the history
The invoked functions already return zero on success or a negative
errno code so there is no need to open code the logic in the caller.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
  • Loading branch information
Javier Martinez Canillas authored and Lee Jones committed Oct 30, 2015
1 parent e7238fd commit d8498df
Showing 1 changed file with 2 additions and 12 deletions.
14 changes: 2 additions & 12 deletions drivers/mfd/kempld-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,6 @@ static int kempld_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev;
struct kempld_device_data *pld;
struct resource *ioport;
int ret;

pld = devm_kzalloc(dev, sizeof(*pld), GFP_KERNEL);
if (!pld)
Expand All @@ -471,11 +470,7 @@ static int kempld_probe(struct platform_device *pdev)
mutex_init(&pld->lock);
platform_set_drvdata(pdev, pld);

ret = kempld_detect_device(pld);
if (ret)
return ret;

return 0;
return kempld_detect_device(pld);
}

static int kempld_remove(struct platform_device *pdev)
Expand Down Expand Up @@ -756,7 +751,6 @@ MODULE_DEVICE_TABLE(dmi, kempld_dmi_table);
static int __init kempld_init(void)
{
const struct dmi_system_id *id;
int ret;

if (force_device_id[0]) {
for (id = kempld_dmi_table;
Expand All @@ -771,11 +765,7 @@ static int __init kempld_init(void)
return -ENODEV;
}

ret = platform_driver_register(&kempld_driver);
if (ret)
return ret;

return 0;
return platform_driver_register(&kempld_driver);
}

static void __exit kempld_exit(void)
Expand Down

0 comments on commit d8498df

Please sign in to comment.