Skip to content

Commit

Permalink
drm/i915: Expose RPS thresholds in sysfs
Browse files Browse the repository at this point in the history
User feedback indicates significant performance gains are possible in
specific games with non default RPS up/down thresholds.

Expose these tunables via sysfs which will allow users to achieve best
performance when running games and best power efficiency elsewhere.

Note this patch supports non GuC based platforms only.

v2:
 * Make checkpatch happy.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
References: https://gitlab.freedesktop.org/drm/intel/-/issues/8389
Cc: Rodrigo Vivi <rodrigo.vivi@kernel.org>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230717164013.826614-4-tvrtko.ursulin@linux.intel.com
  • Loading branch information
Tvrtko Ursulin committed Jul 19, 2023
1 parent c1be616 commit d84990a
Showing 1 changed file with 108 additions and 0 deletions.
108 changes: 108 additions & 0 deletions drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c
Original file line number Diff line number Diff line change
Expand Up @@ -700,6 +700,80 @@ static const struct attribute *media_perf_power_attrs[] = {
NULL
};

static ssize_t
rps_up_threshold_pct_show(struct kobject *kobj, struct kobj_attribute *attr,
char *buf)
{
struct intel_gt *gt = intel_gt_sysfs_get_drvdata(kobj, attr->attr.name);
struct intel_rps *rps = &gt->rps;

return sysfs_emit(buf, "%u\n", intel_rps_get_up_threshold(rps));
}

static ssize_t
rps_up_threshold_pct_store(struct kobject *kobj, struct kobj_attribute *attr,
const char *buf, size_t count)
{
struct intel_gt *gt = intel_gt_sysfs_get_drvdata(kobj, attr->attr.name);
struct intel_rps *rps = &gt->rps;
int ret;
u8 val;

ret = kstrtou8(buf, 10, &val);
if (ret)
return ret;

ret = intel_rps_set_up_threshold(rps, val);

return ret == 0 ? count : ret;
}

static struct kobj_attribute rps_up_threshold_pct =
__ATTR(rps_up_threshold_pct,
0664,
rps_up_threshold_pct_show,
rps_up_threshold_pct_store);

static ssize_t
rps_down_threshold_pct_show(struct kobject *kobj, struct kobj_attribute *attr,
char *buf)
{
struct intel_gt *gt = intel_gt_sysfs_get_drvdata(kobj, attr->attr.name);
struct intel_rps *rps = &gt->rps;

return sysfs_emit(buf, "%u\n", intel_rps_get_down_threshold(rps));
}

static ssize_t
rps_down_threshold_pct_store(struct kobject *kobj, struct kobj_attribute *attr,
const char *buf, size_t count)
{
struct intel_gt *gt = intel_gt_sysfs_get_drvdata(kobj, attr->attr.name);
struct intel_rps *rps = &gt->rps;
int ret;
u8 val;

ret = kstrtou8(buf, 10, &val);
if (ret)
return ret;

ret = intel_rps_set_down_threshold(rps, val);

return ret == 0 ? count : ret;
}

static struct kobj_attribute rps_down_threshold_pct =
__ATTR(rps_down_threshold_pct,
0664,
rps_down_threshold_pct_show,
rps_down_threshold_pct_store);

static const struct attribute * const gen6_gt_rps_attrs[] = {
&rps_up_threshold_pct.attr,
&rps_down_threshold_pct.attr,
NULL
};

static ssize_t
default_min_freq_mhz_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)
{
Expand All @@ -722,9 +796,37 @@ default_max_freq_mhz_show(struct kobject *kobj, struct kobj_attribute *attr, cha
static struct kobj_attribute default_max_freq_mhz =
__ATTR(rps_max_freq_mhz, 0444, default_max_freq_mhz_show, NULL);

static ssize_t
default_rps_up_threshold_pct_show(struct kobject *kobj,
struct kobj_attribute *attr,
char *buf)
{
struct intel_gt *gt = kobj_to_gt(kobj->parent);

return sysfs_emit(buf, "%u\n", gt->defaults.rps_up_threshold);
}

static struct kobj_attribute default_rps_up_threshold_pct =
__ATTR(rps_up_threshold_pct, 0444, default_rps_up_threshold_pct_show, NULL);

static ssize_t
default_rps_down_threshold_pct_show(struct kobject *kobj,
struct kobj_attribute *attr,
char *buf)
{
struct intel_gt *gt = kobj_to_gt(kobj->parent);

return sysfs_emit(buf, "%u\n", gt->defaults.rps_down_threshold);
}

static struct kobj_attribute default_rps_down_threshold_pct =
__ATTR(rps_down_threshold_pct, 0444, default_rps_down_threshold_pct_show, NULL);

static const struct attribute * const rps_defaults_attrs[] = {
&default_min_freq_mhz.attr,
&default_max_freq_mhz.attr,
&default_rps_up_threshold_pct.attr,
&default_rps_down_threshold_pct.attr,
NULL
};

Expand Down Expand Up @@ -752,6 +854,12 @@ static int intel_sysfs_rps_init(struct intel_gt *gt, struct kobject *kobj)
if (IS_VALLEYVIEW(gt->i915) || IS_CHERRYVIEW(gt->i915))
ret = sysfs_create_file(kobj, vlv_attr);

if (is_object_gt(kobj) && !intel_uc_uses_guc_slpc(&gt->uc)) {
ret = sysfs_create_files(kobj, gen6_gt_rps_attrs);
if (ret)
return ret;
}

return ret;
}

Expand Down

0 comments on commit d84990a

Please sign in to comment.