Skip to content

Commit

Permalink
rtlwifi: rtl818x: constify local structures
Browse files Browse the repository at this point in the history
For structure types defined in the same file or local header files, find
top-level static structure declarations that have the following
properties:
1. Never reassigned.
2. Address never taken
3. Not passed to a top-level macro call
4. No pointer or array-typed field passed to a function or stored in a
variable.
Declare structures having all of these properties as const.

Done using Coccinelle.
Based on a suggestion by Joe Perches <joe@perches.com>.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
  • Loading branch information
Julia Lawall authored and Kalle Valo committed Sep 14, 2016
1 parent 1dc8079 commit d86e647
Show file tree
Hide file tree
Showing 8 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion drivers/net/wireless/realtek/rtlwifi/rtl8188ee/sw.c
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ static struct rtl_mod_params rtl88ee_mod_params = {
.debug = DBG_EMERG,
};

static struct rtl_hal_cfg rtl88ee_hal_cfg = {
static const struct rtl_hal_cfg rtl88ee_hal_cfg = {
.bar_id = 2,
.write_readback = true,
.name = "rtl88e_pci",
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/wireless/realtek/rtlwifi/rtl8192ce/sw.c
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ static struct rtl_mod_params rtl92ce_mod_params = {
.debug = DBG_EMERG,
};

static struct rtl_hal_cfg rtl92ce_hal_cfg = {
static const struct rtl_hal_cfg rtl92ce_hal_cfg = {
.bar_id = 2,
.write_readback = true,
.name = "rtl92c_pci",
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/wireless/realtek/rtlwifi/rtl8192de/sw.c
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ static struct rtl_mod_params rtl92de_mod_params = {
.debug = DBG_EMERG,
};

static struct rtl_hal_cfg rtl92de_hal_cfg = {
static const struct rtl_hal_cfg rtl92de_hal_cfg = {
.bar_id = 2,
.write_readback = true,
.name = "rtl8192de",
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/wireless/realtek/rtlwifi/rtl8192ee/sw.c
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ static struct rtl_mod_params rtl92ee_mod_params = {
.debug = DBG_EMERG,
};

static struct rtl_hal_cfg rtl92ee_hal_cfg = {
static const struct rtl_hal_cfg rtl92ee_hal_cfg = {
.bar_id = 2,
.write_readback = true,
.name = "rtl92ee_pci",
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/wireless/realtek/rtlwifi/rtl8192se/sw.c
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ static struct rtl_mod_params rtl92se_mod_params = {

/* Because memory R/W bursting will cause system hang/crash
* for 92se, so we don't read back after every write action */
static struct rtl_hal_cfg rtl92se_hal_cfg = {
static const struct rtl_hal_cfg rtl92se_hal_cfg = {
.bar_id = 1,
.write_readback = false,
.name = "rtl92s_pci",
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/wireless/realtek/rtlwifi/rtl8723ae/sw.c
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ static struct rtl_mod_params rtl8723e_mod_params = {
.disable_watchdog = false,
};

static struct rtl_hal_cfg rtl8723e_hal_cfg = {
static const struct rtl_hal_cfg rtl8723e_hal_cfg = {
.bar_id = 2,
.write_readback = true,
.name = "rtl8723e_pci",
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/wireless/realtek/rtlwifi/rtl8723be/sw.c
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ static struct rtl_mod_params rtl8723be_mod_params = {
.ant_sel = 0,
};

static struct rtl_hal_cfg rtl8723be_hal_cfg = {
static const struct rtl_hal_cfg rtl8723be_hal_cfg = {
.bar_id = 2,
.write_readback = true,
.name = "rtl8723be_pci",
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/wireless/realtek/rtlwifi/rtl8821ae/sw.c
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ static struct rtl_mod_params rtl8821ae_mod_params = {
.disable_watchdog = 0,
};

static struct rtl_hal_cfg rtl8821ae_hal_cfg = {
static const struct rtl_hal_cfg rtl8821ae_hal_cfg = {
.bar_id = 2,
.write_readback = true,
.name = "rtl8821ae_pci",
Expand Down

0 comments on commit d86e647

Please sign in to comment.