Skip to content

Commit

Permalink
[media] SoC Camera: ov6650: minor cleanups
Browse files Browse the repository at this point in the history
This is a followup patch that addresses two minor issues left in the recently
added ov6650 sensor driver, as I've promised to the subsystem maintainer:
- remove a pair of extra brackets,
- drop useless case for not possible v4l2_mbus_pixelcode enum value of 0.

Created against linux-2.6.37-rc1.

Signed-off-by: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Janusz Krzysztofik authored and Mauro Carvalho Chehab committed Nov 9, 2010
1 parent 4b35e62 commit d889eb1
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/media/video/ov6650.c
Original file line number Diff line number Diff line change
Expand Up @@ -754,7 +754,7 @@ static int ov6650_g_fmt(struct v4l2_subdev *sd,

static bool is_unscaled_ok(int width, int height, struct v4l2_rect *rect)
{
return (width > rect->width >> 1 || height > rect->height >> 1);
return width > rect->width >> 1 || height > rect->height >> 1;
}

static u8 to_clkrc(struct v4l2_fract *timeperframe,
Expand Down Expand Up @@ -840,8 +840,6 @@ static int ov6650_s_fmt(struct v4l2_subdev *sd, struct v4l2_mbus_framefmt *mf)
coma_mask |= COMA_BW | COMA_BYTE_SWAP | COMA_WORD_SWAP;
coma_set |= COMA_RAW_RGB | COMA_RGB;
break;
case 0:
break;
default:
dev_err(&client->dev, "Pixel format not handled: 0x%x\n", code);
return -EINVAL;
Expand Down

0 comments on commit d889eb1

Please sign in to comment.