Skip to content

Commit

Permalink
objtool: Change UNWIND_HINT() argument order
Browse files Browse the repository at this point in the history
The most important argument is 'type', make that one first.

Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/r/d994f8c29376c5618c75698df28fc03b52d3a868.1677683419.git.jpoimboe@kernel.org
  • Loading branch information
Josh Poimboeuf authored and Peter Zijlstra committed Mar 23, 2023
1 parent 1c0c1fa commit d88ebba
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion arch/x86/include/asm/unwind_hints.h
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
#else

#define UNWIND_HINT_FUNC \
UNWIND_HINT(ORC_REG_SP, 8, UNWIND_HINT_TYPE_FUNC, 0, 0)
UNWIND_HINT(UNWIND_HINT_TYPE_FUNC, ORC_REG_SP, 8, 0, 0)

#endif /* __ASSEMBLY__ */

Expand Down
5 changes: 2 additions & 3 deletions include/linux/objtool.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

#ifndef __ASSEMBLY__

#define UNWIND_HINT(sp_reg, sp_offset, type, signal, end) \
#define UNWIND_HINT(type, sp_reg, sp_offset, signal, end) \
"987: \n\t" \
".pushsection .discard.unwind_hints\n\t" \
/* struct unwind_hint */ \
Expand Down Expand Up @@ -137,8 +137,7 @@

#ifndef __ASSEMBLY__

#define UNWIND_HINT(sp_reg, sp_offset, type, signal, end) \
"\n\t"
#define UNWIND_HINT(type, sp_reg, sp_offset, signal, end) "\n\t"
#define STACK_FRAME_NON_STANDARD(func)
#define STACK_FRAME_NON_STANDARD_FP(func)
#define ANNOTATE_NOENDBR
Expand Down

0 comments on commit d88ebba

Please sign in to comment.