Skip to content

Commit

Permalink
fbdev: ssd1307fb: fix a possible NULL dereference
Browse files Browse the repository at this point in the history
of_match_device could return NULL, and so cause a NULL pointer
dereference later.

For fixing this problem, we use of_device_get_match_data(), this will
simplify the code a little by using a standard function for
getting the match data.

Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
  • Loading branch information
LABBE Corentin authored and Tomi Valkeinen committed Sep 27, 2016
1 parent 60169c3 commit d8ed9e8
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/video/fbdev/ssd1307fb.c
Original file line number Diff line number Diff line change
Expand Up @@ -559,8 +559,7 @@ static int ssd1307fb_probe(struct i2c_client *client,
par->info = info;
par->client = client;

par->device_info = of_match_device(ssd1307fb_of_match,
&client->dev)->data;
par->device_info = of_device_get_match_data(&client->dev);

par->reset = of_get_named_gpio(client->dev.of_node,
"reset-gpios", 0);
Expand Down

0 comments on commit d8ed9e8

Please sign in to comment.