Skip to content

Commit

Permalink
ibmvnic: Move active sub-crq count settings
Browse files Browse the repository at this point in the history
Inpreparation for using the active scrq count to track more active
resources, move the setting of the active count to after initialization
occurs in initial driver init and during driver reset.

Signed-off-by: Nathan Fontenot <nfont@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Nathan Fontenot authored and David S. Miller committed Feb 21, 2018
1 parent 8862541 commit d9043c1
Showing 1 changed file with 7 additions and 10 deletions.
17 changes: 7 additions & 10 deletions drivers/net/ethernet/ibm/ibmvnic.c
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,6 @@ static void release_rx_pools(struct ibmvnic_adapter *adapter)

kfree(adapter->rx_pool);
adapter->rx_pool = NULL;
adapter->num_active_rx_scrqs = 0;
}

static int init_rx_pools(struct net_device *netdev)
Expand All @@ -509,8 +508,6 @@ static int init_rx_pools(struct net_device *netdev)
return -1;
}

adapter->num_active_rx_scrqs = 0;

for (i = 0; i < rxadd_subcrqs; i++) {
rx_pool = &adapter->rx_pool[i];

Expand Down Expand Up @@ -554,8 +551,6 @@ static int init_rx_pools(struct net_device *netdev)
rx_pool->next_free = 0;
}

adapter->num_active_rx_scrqs = rxadd_subcrqs;

return 0;
}

Expand Down Expand Up @@ -624,7 +619,6 @@ static void release_tx_pools(struct ibmvnic_adapter *adapter)

kfree(adapter->tx_pool);
adapter->tx_pool = NULL;
adapter->num_active_tx_scrqs = 0;
}

static int init_tx_pools(struct net_device *netdev)
Expand All @@ -641,8 +635,6 @@ static int init_tx_pools(struct net_device *netdev)
if (!adapter->tx_pool)
return -1;

adapter->num_active_tx_scrqs = 0;

for (i = 0; i < tx_subcrqs; i++) {
tx_pool = &adapter->tx_pool[i];

Expand Down Expand Up @@ -690,8 +682,6 @@ static int init_tx_pools(struct net_device *netdev)
tx_pool->producer_index = 0;
}

adapter->num_active_tx_scrqs = tx_subcrqs;

return 0;
}

Expand Down Expand Up @@ -991,6 +981,10 @@ static int init_resources(struct ibmvnic_adapter *adapter)
return rc;

rc = init_tx_pools(netdev);

adapter->num_active_tx_scrqs = adapter->req_tx_queues;
adapter->num_active_rx_scrqs = adapter->req_rx_queues;

return rc;
}

Expand Down Expand Up @@ -1692,6 +1686,9 @@ static int do_reset(struct ibmvnic_adapter *adapter,
release_tx_pools(adapter);
init_rx_pools(netdev);
init_tx_pools(netdev);

adapter->num_active_tx_scrqs = adapter->req_tx_queues;
adapter->num_active_rx_scrqs = adapter->req_rx_queues;
} else {
rc = reset_tx_pools(adapter);
if (rc)
Expand Down

0 comments on commit d9043c1

Please sign in to comment.