Skip to content

Commit

Permalink
firmware: bcm47xx_sprom: Fix -Wmissing-prototypes warnings
Browse files Browse the repository at this point in the history
bcm47xx_sprom.h did not include a prototype for bcm47xx_fill_sprom()
therefore add one, and make sure we do include that header to fix
-Wmissing-prototypes warnings.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
  • Loading branch information
Florian Fainelli authored and Thomas Bogendoerfer committed Aug 17, 2020
1 parent 08b5666 commit d92aabc
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
1 change: 1 addition & 0 deletions drivers/firmware/broadcom/bcm47xx_sprom.c
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
*/

#include <linux/bcm47xx_nvram.h>
#include <linux/bcm47xx_sprom.h>
#include <linux/bcma/bcma.h>
#include <linux/etherdevice.h>
#include <linux/if_ether.h>
Expand Down
10 changes: 10 additions & 0 deletions include/linux/bcm47xx_sprom.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,19 @@
#include <linux/kernel.h>
#include <linux/vmalloc.h>

struct ssb_sprom;

#ifdef CONFIG_BCM47XX_SPROM
void bcm47xx_fill_sprom(struct ssb_sprom *sprom, const char *prefix,
bool fallback);
int bcm47xx_sprom_register_fallbacks(void);
#else
static inline void bcm47xx_fill_sprom(struct ssb_sprom *sprom,
const char *prefix,
bool fallback)
{
}

static inline int bcm47xx_sprom_register_fallbacks(void)
{
return -ENOTSUPP;
Expand Down

0 comments on commit d92aabc

Please sign in to comment.