Skip to content

Commit

Permalink
drm/tegra: sor: Root debugfs files at the connector
Browse files Browse the repository at this point in the history
Rather create new files within the top-level DRM device's debugfs node,
add the SOR specific files to the connector's debugfs node. This avoids
the need to come up with subdirectory names and is also more intuitive.

Signed-off-by: Thierry Reding <treding@nvidia.com>
  • Loading branch information
Thierry Reding committed Dec 13, 2017
1 parent 1d60047 commit d92e600
Showing 1 changed file with 6 additions and 11 deletions.
17 changes: 6 additions & 11 deletions drivers/gpu/drm/tegra/sor.c
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,6 @@ struct tegra_sor {

struct drm_info_list *debugfs_files;
struct drm_minor *minor;
struct dentry *debugfs;

const struct tegra_sor_ops *ops;

Expand Down Expand Up @@ -1260,14 +1259,10 @@ static const struct drm_info_list debugfs_files[] = {
static int tegra_sor_debugfs_init(struct tegra_sor *sor,
struct drm_minor *minor)
{
const char *name = sor->soc->supports_dp ? "sor1" : "sor";
struct dentry *root = sor->output.connector.debugfs_entry;
unsigned int i;
int err;

sor->debugfs = debugfs_create_dir(name, minor->debugfs_root);
if (!sor->debugfs)
return -ENOMEM;

sor->debugfs_files = kmemdup(debugfs_files, sizeof(debugfs_files),
GFP_KERNEL);
if (!sor->debugfs_files) {
Expand All @@ -1280,7 +1275,7 @@ static int tegra_sor_debugfs_init(struct tegra_sor *sor,

err = drm_debugfs_create_files(sor->debugfs_files,
ARRAY_SIZE(debugfs_files),
sor->debugfs, minor);
root, minor);
if (err < 0)
goto free;

Expand All @@ -1292,22 +1287,22 @@ static int tegra_sor_debugfs_init(struct tegra_sor *sor,
kfree(sor->debugfs_files);
sor->debugfs_files = NULL;
remove:
debugfs_remove_recursive(sor->debugfs);
sor->debugfs = NULL;
debugfs_remove_recursive(root);
return err;
}

static void tegra_sor_debugfs_exit(struct tegra_sor *sor)
{
struct dentry *root = sor->output.connector.debugfs_entry;

drm_debugfs_remove_files(sor->debugfs_files, ARRAY_SIZE(debugfs_files),
sor->minor);
sor->minor = NULL;

kfree(sor->debugfs_files);
sor->debugfs_files = NULL;

debugfs_remove_recursive(sor->debugfs);
sor->debugfs = NULL;
debugfs_remove_recursive(root);
}

static void tegra_sor_connector_reset(struct drm_connector *connector)
Expand Down

0 comments on commit d92e600

Please sign in to comment.