Skip to content

Commit

Permalink
HID: wiimote: use dev_to_wii()
Browse files Browse the repository at this point in the history
Use dev_to_wii() instead of open-coding it.

Signed-off-by: Geliang Tang <geliangtang@163.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
  • Loading branch information
Geliang Tang authored and Jiri Kosina committed Dec 28, 2015
1 parent ba91a96 commit d98ba98
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions drivers/hid/hid-wiimote-modules.c
Original file line number Diff line number Diff line change
Expand Up @@ -296,14 +296,12 @@ static const struct wiimod_ops wiimod_battery = {

static enum led_brightness wiimod_led_get(struct led_classdev *led_dev)
{
struct wiimote_data *wdata;
struct device *dev = led_dev->dev->parent;
struct wiimote_data *wdata = dev_to_wii(dev);
int i;
unsigned long flags;
bool value = false;

wdata = hid_get_drvdata(container_of(dev, struct hid_device, dev));

for (i = 0; i < 4; ++i) {
if (wdata->leds[i] == led_dev) {
spin_lock_irqsave(&wdata->state.lock, flags);
Expand All @@ -319,14 +317,12 @@ static enum led_brightness wiimod_led_get(struct led_classdev *led_dev)
static void wiimod_led_set(struct led_classdev *led_dev,
enum led_brightness value)
{
struct wiimote_data *wdata;
struct device *dev = led_dev->dev->parent;
struct wiimote_data *wdata = dev_to_wii(dev);
int i;
unsigned long flags;
__u8 state, flag;

wdata = hid_get_drvdata(container_of(dev, struct hid_device, dev));

for (i = 0; i < 4; ++i) {
if (wdata->leds[i] == led_dev) {
flag = WIIPROTO_FLAG_LED(i + 1);
Expand Down

0 comments on commit d98ba98

Please sign in to comment.