Skip to content

Commit

Permalink
fpga: socfpga-a10: disable clk on error in socfpga_a10_fpga_probe()
Browse files Browse the repository at this point in the history
If fpga_mgr_register() fails, a clock is left undisabled.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Reviewed-by: Moritz Fischer <mdf@kernel.org>
Signed-off-by: Alan Tull <atull@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Alexey Khoroshilov authored and Greg Kroah-Hartman committed Dec 18, 2017
1 parent 8d52af6 commit d9cc5a0
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion drivers/fpga/socfpga-a10.c
Original file line number Diff line number Diff line change
Expand Up @@ -519,8 +519,14 @@ static int socfpga_a10_fpga_probe(struct platform_device *pdev)
return -EBUSY;
}

return fpga_mgr_register(dev, "SoCFPGA Arria10 FPGA Manager",
ret = fpga_mgr_register(dev, "SoCFPGA Arria10 FPGA Manager",
&socfpga_a10_fpga_mgr_ops, priv);
if (ret) {
clk_disable_unprepare(priv->clk);
return ret;
}

return 0;
}

static int socfpga_a10_fpga_remove(struct platform_device *pdev)
Expand Down

0 comments on commit d9cc5a0

Please sign in to comment.