Skip to content

Commit

Permalink
pwm: lpss: Move clk_rate check to ->probe()
Browse files Browse the repository at this point in the history
There is no need to check each time if the clk_rate defined or not when we call
pwm_lpss_config(). Move the check to ->probe() instead.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
  • Loading branch information
Andy Shevchenko authored and Thierry Reding committed Jul 11, 2016
1 parent b89b4b7 commit d9cd4a7
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions drivers/pwm/pwm-lpss.c
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ static int pwm_lpss_config(struct pwm_chip *chip, struct pwm_device *pwm,
{
struct pwm_lpss_chip *lpwm = to_lpwm(chip);
unsigned long long on_time_div;
unsigned long c, base_unit_range;
unsigned long c = lpwm->info->clk_rate, base_unit_range;
unsigned long long base_unit, freq = NSEC_PER_SEC;
u32 ctrl;

Expand All @@ -105,10 +105,6 @@ static int pwm_lpss_config(struct pwm_chip *chip, struct pwm_device *pwm,
base_unit_range = BIT(lpwm->info->base_unit_bits);
freq *= base_unit_range;

c = lpwm->info->clk_rate;
if (!c)
return -EINVAL;

base_unit = DIV_ROUND_CLOSEST_ULL(freq, c);

if (duty_ns <= 0)
Expand Down Expand Up @@ -169,6 +165,7 @@ struct pwm_lpss_chip *pwm_lpss_probe(struct device *dev, struct resource *r,
const struct pwm_lpss_boardinfo *info)
{
struct pwm_lpss_chip *lpwm;
unsigned long c;
int ret;

lpwm = devm_kzalloc(dev, sizeof(*lpwm), GFP_KERNEL);
Expand All @@ -180,6 +177,11 @@ struct pwm_lpss_chip *pwm_lpss_probe(struct device *dev, struct resource *r,
return ERR_CAST(lpwm->regs);

lpwm->info = info;

c = lpwm->info->clk_rate;
if (!c)
return ERR_PTR(-EINVAL);

lpwm->chip.dev = dev;
lpwm->chip.ops = &pwm_lpss_ops;
lpwm->chip.base = -1;
Expand Down

0 comments on commit d9cd4a7

Please sign in to comment.