Skip to content

Commit

Permalink
NFC: nci: Extend virtual NCI deinit test
Browse files Browse the repository at this point in the history
Extend the test to check the scenario when NCI core tries to send data
to already closed device to ensure that nothing bad happens.

Signed-off-by: Dmitry Vyukov <dvyukov@google.com>
Cc: Bongsu Jeon <bongsu.jeon@samsung.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Dmitry Vyukov authored and David S. Miller committed Nov 21, 2022
1 parent 148b1da commit d9e8da5
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions tools/testing/selftests/nci/nci_dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -888,6 +888,17 @@ TEST_F(NCI, deinit)
&msg);
ASSERT_EQ(rc, 0);
EXPECT_EQ(get_dev_enable_state(&msg), 0);

/* Test that operations that normally send packets to the driver
* don't cause issues when the device is already closed.
* Note: the send of NFC_CMD_DEV_UP itself still succeeds it's just
* that the device won't actually be up.
*/
close(self->virtual_nci_fd);
self->virtual_nci_fd = -1;
rc = send_cmd_with_idx(self->sd, self->fid, self->pid,
NFC_CMD_DEV_UP, self->dev_idex);
EXPECT_EQ(rc, 0);
}

TEST_HARNESS_MAIN

0 comments on commit d9e8da5

Please sign in to comment.