Skip to content

Commit

Permalink
target: Clean up logic in transport_put_cmd()
Browse files Browse the repository at this point in the history
No need to have a goto where a return is clearer.

Signed-off-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: Nicholas Bellinger <nab@risingtidesystems.com>
  • Loading branch information
Roland Dreier authored and Nicholas Bellinger committed Nov 28, 2012
1 parent 06e97b4 commit d9ed694
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions drivers/target/target_core_transport.c
Original file line number Diff line number Diff line change
Expand Up @@ -1966,9 +1966,10 @@ static void transport_put_cmd(struct se_cmd *cmd)
unsigned long flags;

spin_lock_irqsave(&cmd->t_state_lock, flags);
if (atomic_read(&cmd->t_fe_count)) {
if (!atomic_dec_and_test(&cmd->t_fe_count))
goto out_busy;
if (atomic_read(&cmd->t_fe_count) &&
!atomic_dec_and_test(&cmd->t_fe_count)) {
spin_unlock_irqrestore(&cmd->t_state_lock, flags);
return;
}

if (cmd->transport_state & CMD_T_DEV_ACTIVE) {
Expand All @@ -1980,8 +1981,6 @@ static void transport_put_cmd(struct se_cmd *cmd)
transport_free_pages(cmd);
transport_release_cmd(cmd);
return;
out_busy:
spin_unlock_irqrestore(&cmd->t_state_lock, flags);
}

void *transport_kmap_data_sg(struct se_cmd *cmd)
Expand Down

0 comments on commit d9ed694

Please sign in to comment.