Skip to content

Commit

Permalink
um: Don't pollute kernel namespace with uapi
Browse files Browse the repository at this point in the history
Don't include ptrace uapi stuff in arch headers, it will
pollute the kernel namespace and conflict with existing
stuff.
In this case it fixes clashes with common names like R8.

Signed-off-by: Richard Weinberger <richard@nod.at>
  • Loading branch information
Richard Weinberger committed Jun 25, 2015
1 parent 8eeba4e commit da028d5
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 1 deletion.
1 change: 0 additions & 1 deletion arch/um/include/asm/ptrace-generic.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

#ifndef __ASSEMBLY__

#include <asm/ptrace-abi.h>
#include <sysdep/ptrace.h>

struct pt_regs {
Expand Down
1 change: 1 addition & 0 deletions arch/um/kernel/ptrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
#include <linux/sched.h>
#include <linux/tracehook.h>
#include <asm/uaccess.h>
#include <asm/ptrace-abi.h>

void user_enable_single_step(struct task_struct *child)
{
Expand Down
1 change: 1 addition & 0 deletions arch/x86/um/ptrace_32.c
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
#include <linux/mm.h>
#include <linux/sched.h>
#include <asm/uaccess.h>
#include <asm/ptrace-abi.h>
#include <skas.h>

extern int arch_switch_tls(struct task_struct *to);
Expand Down
1 change: 1 addition & 0 deletions arch/x86/um/ptrace_64.c
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
#define __FRAME_OFFSETS
#include <asm/ptrace.h>
#include <asm/uaccess.h>
#include <asm/ptrace-abi.h>

/*
* determines which flags the user has access to.
Expand Down
1 change: 1 addition & 0 deletions arch/x86/um/tls_32.c
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
#include <linux/sched.h>
#include <linux/syscalls.h>
#include <asm/uaccess.h>
#include <asm/ptrace-abi.h>
#include <os.h>
#include <skas.h>
#include <sysdep/tls.h>
Expand Down
1 change: 1 addition & 0 deletions arch/x86/um/tls_64.c
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#include <linux/sched.h>
#include <asm/ptrace-abi.h>

void clear_flushed_tls(struct task_struct *task)
{
Expand Down

0 comments on commit da028d5

Please sign in to comment.